Closed Ilia-Kosenkov closed 1 year ago
but right now is not.
I'm not sure why the things changed, but, if it's fine to you, probably it's fine because the original issue (#198) is what can be found in your development workflow.
If I understand correctly, before we had some fake library files that were built to create libgcc_eh.a. So this hack forced the build process, emitting all necessary files. Now we write fake library directly in Makevars
https://github.com/extendr/rextendr/blob/main/inst/templates/Makevars.win#L22
Oh I think I am wrong here. I need to verify this
Okay, here's the story.
Until #218, it invoked compilation (configure.ucrt
) to generate the fake lib, so it copied the one that was generated once when the user installs rextendr. But, as it turned out just touching is enough, we stopped the compilation and chose to touch every time.
So basically it is an artefact of a feature that has been removed? Then I guess it is safe to proceed.
Yes, I believe it's safe.
Closes #257.
Remove pkgbuild package installation hack that was previously necessary, but right now is not.