search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
175 stars 25 forks source link

refactor: replace map_dfr family to map + bind_rows #272

Closed eitsupi closed 1 year ago

eitsupi commented 1 year ago

Close #266

JosiahParry commented 1 year ago

I suggest to rely upon dplyr::bind_rows() so you do not need to set the minimum version of purrr

eitsupi commented 1 year ago

I don't know why you are against setting a minimum version of purrr.

JosiahParry commented 1 year ago

Simplifying the dependency tree for users is generally good. Forcing them to upgrade to purrr v1.0—which has breaking changes—may have unintended consequences for the rest of their work. Not everyone has renv.lock files for each of their projects and may not know immediately (or have the time to) how to remediate the errors introduced by using purrr 1.x

Ilia-Kosenkov commented 1 year ago

I second the suggestion to go dplyr::bind_rows(). We already have this dependency, and it is one of the recommended ways of replacing purrr::map_dfr().

eitsupi commented 1 year ago

I replaced list_rbind to bind_rows.