search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
175 stars 25 forks source link

test: enable tests on CRAN #294

Closed eitsupi closed 1 year ago

eitsupi commented 1 year ago

https://github.com/extendr/rextendr/pull/280#issuecomment-1559654027

Ilia-Kosenkov commented 1 year ago

Oh you are running ahead of me in this :) Did you try submitting it to CRAN-like runners?

eitsupi commented 1 year ago

Oh you are running ahead of me in this :) Did you try submitting it to CRAN-like runners?

No. So there is still a possibility of problems when submitting CRANs.

Particular attention should be paid to cases where files are generated by writing to the home directory, etc.

Ilia-Kosenkov commented 1 year ago

Can we submit it to r-hub or something similar?

eitsupi commented 1 year ago

~~Perhaps the results of the R-hub runs will be sent to the maintainer's email address? Could you check out this branch and run devtools::check_rhub() to test it?~~

Edit: I updated DESCRIPTION file and run devtools::check_rhub() locally.

Edit: devtools::check_rhub() has the email option to set the email address to notify.

eitsupi commented 1 year ago

@Ilia-Kosenkov The R-hub builders seem to pass the test successfully.

skip_if_cargo_bin was causing errors on Windows, but 5a73471 fix that.