extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
175 stars 25 forks source link

[DRAFT - feedback needed] Sync crate and R package versions #307

Closed JosiahParry closed 6 months ago

JosiahParry commented 11 months ago

This PR closes https://github.com/extendr/rextendr/issues/304 and is related to #228.

This draft creates two functions use_version() and sync_version().

I personally think masking functions from usethis is a little questionable. I like the workflow of:

Alternatively, we could change the name of use_version() to increment_version() to avoid namespace conflicts.

JosiahParry commented 11 months ago

CC @eitsupi I would like your eyes on this! I opted for cargo-bump since it is easier to use and isn't tied to actually publishing a crate.

eitsupi commented 11 months ago

I opted for cargo-bump since it is easier to use and isn't tied to actually publishing a crate.

cargo-bump does not seem to be currently maintained and is not recommended to be used.

JosiahParry commented 11 months ago

Sure, thats fine. More importantly, though, is the user experience. Do you prefer masking usethis?

eitsupi commented 11 months ago

Do you prefer masking usethis?

I would also prefer to update only Cargo.toml without wrapping the usethis function as you suggested.