Closed JosiahParry closed 6 months ago
@Ilia-Kosenkov I cannot figure out what the error is with these snapshot tests for testing vendoring output. @CGMossa was able to pull the branch, run the tests, and they all passed. Do you have any idea what might be causing the failure? I'm tempted to remove to test all together to appease the CI gods.
Ok let me check
I got this snapshot failure -- you incorrectly parsed stdout
Which is yet different than the CI errors 🙈 ! Thank you for testing
Maybe you can extract vendored packages (if I udnerstand your logic) using this regex?
Vendoring\s([a-z0-9_][a-z0-9_-]*?)(?=\s)\s(.+?)(?=\s)
You changed snapshot to snapshot x
, but the actual snapshot still has print(x)
, hence it complains :)
@Ilia-Kosenkov true! But i don't think that's the core of the problem. If you look at the CI output nothing is showing up :O
I'll save it for another time.
Yep which means some sort of parsing had failed. I will check this out in an hour or so
The reason I insist on this is that I believe this flaky test shows instability in parsing, which may negatively affect users. So we better figure it out
@JosiahParry , can I push to your branch here?
@Ilia-Kosenkov confirmed
@Ilia-Kosenkov your changes have fixed CI! I've added a note to NEWS.md as well.
I'd like to revisit this PR. I used this fork to publish {arcpbf} to CRAN. Using these functions has made it very easy to publish extendr packages to CRAN. There was no back and forth about the use of Rust in this package, no back and forth about the build or compilation process etc.
I think making it easy to publish extendr packages to CRAN is the best way to make this project widely useful and interesting.
Please let me know what is needed to merge this PR.
Hey @JosiahParry , what' the status of this PR?
Please let me know what is needed to merge this PR
What do you need from me to merge this PR? I've been using it myself for cran publications.
Tests are failing due to version mismatch, can you pull it locally and run tests - it should tell you which snapshot is wrong.
And add a reference to your Pr in News.md, I think it is missing
Cool sounds good! I'll appease PR gods tomorrow-ish and update news to get this through!
Looks solid! If you have no more changes to make @JosiahParry , should we merge it?
No more changes from me at this time :)
This PR superceds #313. The purpose of this PR is create a pathforward for developers who wish to publish extendr packages on CRAN. It is based on prqlr and my experience publishing rsgeo to CRAN.
The PR adds:
use_cran_defaults()
which addsconfigure
andconfigure.win
files, modifiesMakevars
andMakevars.win
to use CRAN requirementsvendor_pkgs()
which vendors crates appropriatelycargo generate-lockfile
for brand new packages without aCargo.lock
filevendor-config.toml
vignettes/articles/cran-compliance.Rmd
which describes the process for making R packages CRAN compliant.It does not add functionality to document crate authors. rsgeo does not do this and has not been problematic in getting the package published—though it may in the future, I am unsure.
Nonetheless, I used these functions to publish rsgeo and it has been successful. This PR provides minimal funcitonality to provide a path forward towards CRAN compliant packages in an opt-in manner.
Follow up tasks