search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
197 stars 27 forks source link

draft of use_crate() #361

Closed kbvernon closed 3 months ago

kbvernon commented 5 months ago

For https://github.com/extendr/rextendr/issues/360

Ilia-Kosenkov commented 3 months ago

Do we need all two files, 400 lines each? Can we trim it only to used functions?

kbvernon commented 3 months ago

Possibly, but if we intend to incrementally update other parts of rextendr to use these standalone checks, maybe we should think about which ones we are likely to use elsewhere (not just for this function) and then trim everything else. What do you think, @JosiahParry?

JosiahParry commented 3 months ago

I think including the files is helpful for the future development of the package. I would suggest to keep them as is.

This is because they add no other dependencies hence "standalone." Together they are 20kb which is very small. If size is a concern we can remove comments and whitespace. But again, this is a utility package, not one that is included in the final binary of another.

kbvernon commented 3 months ago

Awesome! Thanks! If you all want someone to work on integrating/modifying the standalone checks more, I can probably devote some time to it next month.

Ilia-Kosenkov commented 3 months ago

@kbvernon , could you please also update NEWS.md since this is function is a part of public API?

kbvernon commented 3 months ago

can do! thanks, @Ilia-Kosenkov!