extension-js / extension.js

🧩 Plug-and-play, zero-config, cross-browser extension development tool.
https://extension.js.org
MIT License
3.46k stars 80 forks source link

Mainfest file have issue on icons path #87

Closed Ajayghoshm closed 1 week ago

Ajayghoshm commented 1 month ago

image (1) image (2)

these are the actual file and the file being generated, the path of the icons is incorrect, issue is happening in windows system

cezaraugusto commented 1 month ago

Hi @Ajayghoshm thanks for reporting!

I'm not sure what the issue is, could you describe it more fully?

Ajayghoshm commented 1 month ago

The issues is as follows,

When you run dev command, the manifest file being generated inside dist have wrong icon path, the actual icon path is public/icon/icon_16.png, but the generated manifest file only have icon url is incorrect as shown in the screenshots

cezaraugusto commented 1 month ago

I see. Files within public/ should resolve to public/ always. ManifestPlugin should handle that, so that's a bug.