search

exteranto / framework

The Exteranto browser extension framework core packages.
https://exteranto.github.io
MIT License
5 stars 4 forks source link

[tabs] Check for chrome.lastError and reject a promise if found #109

Closed porkbrain closed 5 years ago

porkbrain commented 5 years ago

Describe the bug Tab methods for chrome do not check for lastError, which results in not rejected promises and console pollution.

To reproduce Steps to reproduce the behaviour:

  1. Go to background page console
  2. Try to Tabs.get a nonexisting tab
  3. See error being printed in the console

Expected behaviour Promise to be rejected and lastError to be caught.

kouks commented 5 years ago

Closed by #111