search

exteranto / framework

The Exteranto browser extension framework core packages.
https://exteranto.github.io
MIT License
5 stars 4 forks source link

[storage] Use enum for storage type #80

Closed porkbrain closed 5 years ago

porkbrain commented 5 years ago

It would be better if the Storage constructor took an enum instead of string.

kouks commented 5 years ago

This should be reconsidered altogether. If we want to introduce MemoryStorage, enum is out of the question because we can't merge the memory implementation in one class with the other ones. We would have to define a separate implementation for LocalStorage, SyncStorage and MemoryStorage.

This, however, requires some improvements in the IOC container which I have planned to look at in March after I am less busy.

kouks commented 5 years ago

Closed by #110