search

external-secrets / bitwarden-sdk-server

This repository contains a simple REST wrapper for the Bitwarden Rust SDK
https://external-secrets.io
Apache License 2.0
7 stars 1 forks source link

ARM64 Docker image builds #11

Closed brianramseyau closed 1 month ago

brianramseyau commented 1 month ago

Is your feature request related to a problem? Please describe. Cannot deploy on Raspberry Pi, Apple Silicon, etc.

Describe the solution you'd like Multi-arch builds including ARM

Describe alternatives you've considered N/A

Additional context With ARM clusters and Apple Silicon being more prevalent, it would be nice to have this support sooner rather than later, assuming there are no issues due to upstream.

Skarlso commented 1 month ago

The Rust sdk doesn't support arm builds I'm afraid. 😟

That's one of the reasons this project is separate from ESO. Otherwise ESO's support for wide variety of architectures would have dropped.

volschin commented 1 month ago

As I have seen the bws-cli releases include arm64. https://github.com/bitwarden/sdk/releases Can you explain, which rust sdk?

Skarlso commented 1 month ago

The one this server uses. It's a CGO library where the Rust library creates object files to use here -> https://github.com/bitwarden/sdk-go/tree/main/internal/cinterface/lib

And now that I look at this, it looks like they have arm libs. 😆 😆

I shall investigate.

Skarlso commented 1 month ago

I'll try making some multi-arch docker builds with dockerx.

brianramseyau commented 1 month ago

Oh wow, I did not expect such a quick response and action here. Thank you so much 😀

Skarlso commented 1 month ago

Ah, don't be so sure about that hahahaha. :D I'll have to figure out how to do it first. :D

Skarlso commented 1 month ago

Oh, hopefully it's as easy as adding platforms: linux/amd64,linux/arm64. 🤞

Skarlso commented 1 month ago

Alright, build is running... let's see. :D

Skarlso commented 1 month ago

Well.. that worked. @brianramseyau can you try please?

brianramseyau commented 1 month ago

@Skarlso it's alive! I'm thankful it was a relatively trivial change for this. Apologies for the long delay in replying.. Life got in the way, hah I'll continue in the process today where I can to get it all up and running now this bit starts, and ensure its working entirely as expected.

brianramseyau commented 1 month ago

@Skarlso I can confirm this is working as expected (was a little rocky with getting the right config, but it ended up being unrelated). Thanks heaps for such quick enablement on this one, super happy to be up and running.

Skarlso commented 1 month ago

No worries! I'm super glad it works indeed. 😁

I thought I would have to do some fiddling with the libraries but thankfully it all just worked. Heh. 😏