search

external-secrets / bitwarden-sdk-server

This repository contains a simple REST wrapper for the Bitwarden Rust SDK
https://external-secrets.io
Apache License 2.0
7 stars 1 forks source link

Liveness and readiness probes are left out #14

Closed volschin closed 1 month ago

volschin commented 1 month ago

Describe the bug By default there are no readiness and liveness probes enabled with if tls.

https://github.com/external-secrets/bitwarden-sdk-server/blob/704e397334d79382a513cf79bc6ff2cb8878e38d/deploy/charts/bitwarden-sdk-server/templates/deployment.yaml#L46

To Reproduce Steps to reproduce the behavior:

  1. install external-secrets chart with bitwarden-sdk
  2. check the deployment.yaml

Expected behavior It‘s best practice to have defined readiness and liveness probes by default install.

Additional context in my case a kyverno policy reported the nonconformity.

Skarlso commented 1 month ago

Right you are. I'll add them. :)

Skarlso commented 1 month ago

This needs to be released first.

Skarlso commented 1 month ago

v0.3.0 should contain this fix. :) 🤞