search

extesy / DeckTracker

Universal Deck Tracker for collectible card games such as The Elder Scrolls: Legends and Eternal
Other
96 stars 26 forks source link

Improve presentation of opponent deck types #13

Open AustinYQM opened 7 years ago

AustinYQM commented 7 years ago

Running into strange issue where I have 1 game with a deck and that one game is registering as two deck types.

Here is an image of the tracker.

Here is my current Decktypes.txt for those two deck types.

||Multicolored (FJS)|Colors.Contains("Fire","Justice","Shadow")
|||Infinite Gunsmiths|Cards.ContainsAny(2,"Cabal Spymaster","West-Wind Herald","Calderan Gunsmith")
|||Armory|Cards.ContainsAny(3,"Starsteel Daisho","Icaria, the Liberator","Smuggler's Stash","Rakano Artisan","Quarry","Throne Warden","Harsh Rule","Rise to the Challange","Auric Runehammer")
AustinYQM commented 7 years ago

Judging by this tab it is happening with more than just that deck.

AustinYQM commented 7 years ago

Here is an image of the plate match-ups NOT using my custom Decktypes.txt. It still has extra decks. It says I have played 24 but it has 29 listed.

ghost commented 7 years ago

Not quite related, but shouldn't Infinite Gunsmith be under FPS instead

AustinYQM commented 7 years ago

Yeah I've since moved it! Noticed it after I posted those pictures.

extesy commented 7 years ago

This is actually by design. It's not counted twice - see that "All Games" is still one? It's because your deck is both Armory and FJS at the same time. The reason is because I wanted to make the right list into a tree view instead and just haven't yet figured it out how to display trees in WPF. With the tree structure all child nodes are aggregated into the parent node so it makes sense. I agree that it looks somewhat confusing in the flat list.

extesy commented 7 years ago

For example you want to know your winrate against all FJS decks and not just "all FJS except Armory". So in order to compute this winrate correctly you have to really count all FJS decks, including all subtypes.

AustinYQM commented 7 years ago

Gotcha. So it isn't something I have broken. I will continue adding deck types than.

extesy commented 7 years ago

Thanks for the pull request! Looks great, I'll add the updated list into the next version.