extesy / hoverzoom

Google Chrome extension for zooming images on mouse hover
https://chrome.google.com/webstore/detail/hover-zoom%20/pccckmaobkjjboncdfnnofkonhgpceea
MIT License
1.15k stars 178 forks source link

saving pictures, file extention is not provided after save, so the filename is incomplete. #1116

Closed JRicardoCSouza closed 1 year ago

JRicardoCSouza commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

JRicardoCSouza commented 1 year ago

Using key S to save a picture. On file manager, the file is save without extention: On Pinterest, moving the mouse over a image, I see a 2x image, S key clicked. On folder Downloads a new file was saved: e8a8b009-c4be-4e84-b072-a6c1b26aec54 without extention (jpg, png or gif, ...) I need to rename this file to png

GrosPoulet commented 1 year ago

Hi @JRicardoCSouza I can not reproduce this issue with latest release of HZ+ (1.0.203). I'm using Chrome Version 111.0.5563.146 (Official Build) (64-bit).

image

Do you have same issue on other sites than Pinterest ?

adambnmohd commented 1 year ago

Same issue here Hover Zoom+

Size: 4.8 MBSize4.8 MBVersion: 1 . 0 . 2 0 3Version1.0.203 Microsoft Edge Version 111.0.1661.62 (Official build) (64-bit) image

JRicardoCSouza commented 1 year ago

Good Morning!

I'm from Brasil, and my Win10 is using Portuguese language.

I'm using Versão 1.0.203 (última atualização: qua., 29 de mar. de 2023) - © 2014-2022 Oleg Anashkin

OK! I'm sending a couple of images of the problem:

1-selecting image - Pinterest [image: image.png]

2-Clicking S key - and file was created and saved on Downloads Folder [image: image.png]

3-Opening Downloads Folber [image: image.png]

4-Downloads folder open [image: image.png]

5-File Properties [image: image.png] 6-There wasn't extension

7-Renaming file to Filetype PNG [image: image.png] 8-Opening file [image: image.png]

I hope those pictures could help you!

Thanks

Em sex., 31 de mar. de 2023 às 05:10, GrosPoulet @.***> escreveu:

Hi @JRicardoCSouza https://github.com/JRicardoCSouza I can not reproduce this issue with latest release of HZ+ (1.0.203). I'm using Chrome Version 111.0.5563.146 (Official Build) (64-bit).

— Reply to this email directly, view it on GitHub https://github.com/extesy/hoverzoom/issues/1116#issuecomment-1491496605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJQWKXZR6ZJBB4BSHWUHPDW62GN5ANCNFSM6AAAAAAWN5QE6U . You are receiving this because you were mentioned.Message ID: @.***>

GrosPoulet commented 1 year ago

@adambnmohd on which site did this issue happen ?

adambnmohd commented 1 year ago

@GrosPoulet every site but the ones in the image are from google images, after updating my browser "S"save image doesnt work but "T" for opening it in a new tab does

GrosPoulet commented 1 year ago

I did a clean install on Edge and could not reproduce the issue. @extesy any idea ?

misakitchi commented 1 year ago

Same bug here... :(

extesy commented 1 year ago

@GrosPoulet Tried it both in Chrome and in Edge and can't reproduce it either. Maybe it conflicts with some other extension or maybe there are some browser settings that cause this.

syd-h commented 1 year ago

This also happens for me on Chrome Version 111.0.5563.147 (Official Build) (64-bit).

I did a fresh install in a sandbox and found one of my other extensions is causing this issue for me. It is Image Downloader v3.3.3 for chrome. Back on my main browser if I disable the extension the downloads work like normal again.

v3.3.3 of that extension hasn't been updated since October 14, 2022 also.

adambnmohd commented 1 year ago

might it be something with the latest version? installed the github version of [1.0.202] and everything works

extesy commented 1 year ago

@GrosPoulet Could #1108 cause this? It was added in 1.0.203.

JRicardoCSouza commented 1 year ago

Bug found - Chrome extension - Image Downloader

Thanks

Em seg., 3 de abr. de 2023 às 20:18, Oleg Anashkin @.***> escreveu:

@GrosPoulet https://github.com/GrosPoulet Could #1108 https://github.com/extesy/hoverzoom/pull/1108 cause this? It was added in 1.0.203.

— Reply to this email directly, view it on GitHub https://github.com/extesy/hoverzoom/issues/1116#issuecomment-1495111498, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJQWKTGACU4KF7UGB3FDHLW7NLDHANCNFSM6AAAAAAWN5QE6U . You are receiving this because you were mentioned.Message ID: @.***>

JRicardoCSouza commented 1 year ago

Thanks!

Bug found!

Em dom., 2 de abr. de 2023 às 14:31, syd-h @.***> escreveu:

This also happens for me on Version 111.0.5563.147 (Official Build) (64-bit).

I did a fresh install in a sandbox and found one of my other extensions is causing this issue for me. It is Image Downloader v3.3.3 https://chrome.google.com/webstore/detail/image-downloader/cnpniohnfphhjihaiiggeabnkjhpaldj for chrome. Back on my main browser if I disable the extension the downloads work like normal again.

— Reply to this email directly, view it on GitHub https://github.com/extesy/hoverzoom/issues/1116#issuecomment-1493398040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJQWKRWM35NZ23NOJBOXPTW7GZY5ANCNFSM6AAAAAAWN5QE6U . You are receiving this because you were mentioned.Message ID: @.***>

GrosPoulet commented 1 year ago

1108 probably triggered this issue, i'll give it a look

BobbyBleacher commented 1 year ago

Same issue in the most recent version of chrome. Disabling extension "Double-click Image Downloader" fixes it.

https://chrome.google.com/webstore/detail/double-click-image-downlo/bkijmpolkanhdehnlnabfooghjdokakc

GrosPoulet commented 1 year ago

@extesy issue fixed, it might deserve an emergency release, up to you!

extesy commented 1 year ago

@GrosPoulet Thanks for the fix! I published a new version to Chrome & Edge, but Firefox might have to wait a bit - they have some server-side issues with processing my update.

JRicardoCSouza commented 1 year ago

This issue was resolved:

Same issue in the most recent version of chrome. Disabling extension "Double-click Image Downloader" fixes it.

https://chrome.google.com/webstore/detail/double-click-image-downlo/bkijmpolkanhdehnlnabfooghjdokakc

— Reply to this email directly, view it on GitHub https://github.com/extesy/hoverzoom/issues/1116#issuecomment-1500670337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJQWKSTIEMYAFCQALHYYODXACDHXANCNFSM6AAAAAAWN5QE6U . You are receiving this because you were mentioned.

Em sex., 31 de mar. de 2023 às 05:10, GrosPoulet @.***> escreveu:

Hi @JRicardoCSouza https://github.com/JRicardoCSouza I can not reproduce this issue with latest release of HZ+ (1.0.203). I'm using Chrome Version 111.0.5563.146 (Official Build) (64-bit).

— Reply to this email directly, view it on GitHub https://github.com/extesy/hoverzoom/issues/1116#issuecomment-1491496605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJQWKXZR6ZJBB4BSHWUHPDW62GN5ANCNFSM6AAAAAAWN5QE6U . You are receiving this because you were mentioned.Message ID: @.***>