search

extesy / hoverzoom

Google Chrome extension for zooming images on mouse hover
https://chrome.google.com/webstore/detail/hover-zoom%20/pccckmaobkjjboncdfnnofkonhgpceea
MIT License
1.15k stars 178 forks source link

Changing the codebase to Typescript #450

Open kamalesh0406 opened 5 years ago

kamalesh0406 commented 5 years ago

ATTENTION! If you don't follow this template then your issue will be immediately closed.

Description of the problem

There seems to be to a lot of errors that aren’t being caught because of JavaScript I feel updating the codebase to Typescript might solve a lot of these issues.

Url of the page where the problem occurs (not the image url)

Steps to reproduce the problem (include image url here)

1. 2. 3.

OS version, extension version (Chrome only, Firefox is not supported)

kamalesh0406 commented 5 years ago

@extesy if you are ready I can create a new branch and push the code to it.

extesy commented 5 years ago

@kamalesh0406 Do Chrome and Firefox understand Typescript natively? I would prefer to avoid introducing a special build process because right now there's no build involved in release - I just zip all files and upload to webstore.

kamalesh0406 commented 5 years ago

@extesy there is no native support for typescript we will need to build it to javascript and zip those files. But it is a small price to pay for something better we can also then add travis testing to the repo.