search

exthereum / abi

The Ethereum ABI Interface
MIT License
20 stars 22 forks source link

Fix method ids, and bump version to 0.1.11 #8

Closed tsutsu closed 6 years ago

tsutsu commented 6 years ago

Currently, because of this line, attempting to calculate the method ID for a function-signature containing an type unimplemented in ABI.FunctionSelector.get_type/1 fails to raise an exception, and instead silently returns a corrupted method ID.

This PR fixes the problematic line to actually raise, but goes further by implementing proper get_type/1 support for every standard ABI type. The problematic line should never be reachable now.

hayesgm commented 6 years ago

looks good, thanks

hayesgm commented 6 years ago

https://hex.pm/packages/abi/0.1.11