search

extinctionrebellion / quarantine

In quarantine for #covid19? Share what you need and find neighbours who can help you.
https://quarantine.help
MIT License
2 stars 0 forks source link

Switch to OpenStreetMap #3

Open jbelien opened 4 years ago

jbelien commented 4 years ago

Hello everyone,

Awesome initiative! I joined the Slack channels and would be happy to help with some code.

I see you're using GoogleMaps in the develop branch. I think it's a poor choice and it will be easy to switch to OpenStreetMap using Mapbox GL. Dan said that clustering is required and it's definitely not an issue : https://docs.mapbox.com/mapbox-gl-js/example/cluster/

I don't have much experience with React but that shouldn't be an issue either. There are 2 libraries to use Mapbox GL with React:

I already had a look at the code and switching to Mapbox GL should pretty much be straightforward.

Let me know if I can help !

danielsum commented 4 years ago

Hi Jonathan, ok go for it.

I tried Leaflet and OSM for different project and the problem was always some bugs around the map. But didn't know about Mapbox, it seems very interesting :-)

=> I you want there is an Api with markers so you can just taking care of building the map in whenever technologies you want.

For now there is a /api/v1/markers that list the needs or a /api/v1/search that you can filter markers based on your localisation. (see doc)

Dan

jbelien commented 4 years ago

Okay, I'll give it a try :)