extinctsion / easyPythonpi

A python library for the beginners. The program includes simple calulations. Genuine PRs will be merged without delays
https://pypi.org/project/easyPythonpi/
14 stars 36 forks source link

Add workflow to run tests on pull request #70

Closed Kishore-abhimanyu closed 8 months ago

Kishore-abhimanyu commented 9 months ago

Add workflow to run tests when PR is created or updated

Kishore-abhimanyu commented 9 months ago

@extinctsion Please review the PR and let me know, if any change is required

extinctsion commented 9 months ago

Have you checked it on you branch? is it working? If yes, pls attach a Screenshot of the same.

extinctsion commented 9 months ago

Also pls configure to test for various version of python from py3.7 to latest and also on different platforms such as windows, ubuntu latest and mac.

extinctsion commented 9 months ago

you can take help from this youtube video - https://youtu.be/UEOtZvTCmDo?si=SwfdqnLw-3isB8P3

Kishore-abhimanyu commented 9 months ago

@extinctsion I have added the different python version and different os environments. Also attaching the testing evidence here

Screenshot 2023-10-22 at 5 11 12 PM
extinctsion commented 9 months ago

Hey @Kishore-abhimanyu can you look and tell why the test cases are not running?

Kishore-abhimanyu commented 9 months ago

Hi @extinctsion I have fixed the space issue. As the trigger takes master branch, once the code has been merged with master, going forward for all the PR created, it should be running. For now, I have added the push trigger also, to check, since some of the tests are failing, the other job had been cancelled

extinctsion commented 9 months ago

Still tests are failing. We have to look after this.

extinctsion commented 9 months ago

Also maybe we can merge this and isort workflow together as both are doing task on pull requests? What do you think?

Kishore-abhimanyu commented 9 months ago

Sure we can do that @extinctsion

extinctsion commented 9 months ago

Still the test cases are failing.