search

extinctsion / easyPythonpi

A python library for the beginners. The program includes simple calulations. Genuine PRs will be merged without delays
https://pypi.org/project/easyPythonpi/
14 stars 36 forks source link

Adding Black and Isort to maintain the repository by following python conventions #71

Open Kishore-abhimanyu opened 9 months ago

Kishore-abhimanyu commented 9 months ago

Adding Black and Isort to maintain the repository by following python conventions

Kishore-abhimanyu commented 9 months ago

@extinctsion If you think, this as a needed feature, please assign the issue to me. Would like to work on this issue

extinctsion commented 9 months ago

Can you explain a bit what is isort and black for maintaining this repo?

extinctsion commented 9 months ago

Pls help us identify the requirements then I'll assign you this issue.

Kishore-abhimanyu commented 9 months ago

I can see that the files are not intended properly and some are violating python standing spacing policies. When we add black to the project we can make sure that it is following those standards and we can also add a check in GitHub actions. What do you think?

On Sun, 22 Oct 2023, 22:17 Aditya Sharma, @.***> wrote:

Pls help us identify the requirements then I'll assign you this issue.

— Reply to this email directly, view it on GitHub https://github.com/extinctsion/easyPythonpi/issues/71#issuecomment-1774141460, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARGXF2RGM7BSHJDVWWCI4R3YAVE2ZAVCNFSM6AAAAAA6K5L3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE2DCNBWGA . You are receiving this because you authored the thread.Message ID: @.***>

extinctsion commented 9 months ago

Still not clear 😅. Can you give some links to read and understand or have u implemented it before? Pls share it here.

Kishore-abhimanyu commented 9 months ago

Sure. Find the link below https://pypi.org/project/black/

On Sun, 22 Oct 2023, 23:05 Aditya Sharma, @.***> wrote:

Still not clear 😅. Can you give some links to read and understand or have u implemented it before? Pls share it here.

— Reply to this email directly, view it on GitHub https://github.com/extinctsion/easyPythonpi/issues/71#issuecomment-1774153432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARGXF2VCO6JQDULJDDBN7DDYAVKNPAVCNFSM6AAAAAA6K5L3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE2TGNBTGI . You are receiving this because you authored the thread.Message ID: @.***>

extinctsion commented 9 months ago

Yea, I also searched about it and I think it should be include in this repo. Thanks for giving such amazing idea.

Kishore-abhimanyu commented 9 months ago

You're welcome! Please assign me this issue. I will start to work on it

On Sun, 22 Oct 2023, 23:39 Aditya Sharma, @.***> wrote:

Yea, I also searched about it and I think it should be include in this repo. Thanks for giving such amazing idea.

— Reply to this email directly, view it on GitHub https://github.com/extinctsion/easyPythonpi/issues/71#issuecomment-1774161020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARGXF2S4HVJFDI3V7NRHRK3YAVOOJAVCNFSM6AAAAAA6K5L3G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE3DCMBSGA . You are receiving this because you authored the thread.Message ID: @.***>

extinctsion commented 9 months ago

Sure.

Kishore-abhimanyu commented 9 months ago

Added the PR https://github.com/extinctsion/easyPythonpi/pull/74, please review