Andrew hung nguyen - is_palindrome() fixes and method naming convention changes

extinctsion / easyPythonpi

A python library for the beginners. The program includes simple calulations. Genuine PRs will be merged without delays

https://pypi.org/project/easyPythonpi/

14 stars 36 forks source link

Andrew hung nguyen - is_palindrome() fixes and method naming convention changes #75

Closed AndrewHUNGNguyen closed 9 months ago

AndrewHUNGNguyen commented 9 months ago

Resolved defect on is_palindrome on sentences by removing punctuations, lowercasing letters, and removing spaces.

Added more unit test cases on is_palindrome and changed naming convention of existing unit test cases in stringmanipulation.py for easier readability.

extinctsion commented 9 months ago

Pls fix the test cases for which it was failing. Also adjust other test cases file imports as it was giving path errors.

AndrewHUNGNguyen commented 9 months ago

Pls fix the test cases for which it was failing. Also adjust other test cases file imports as it was giving path errors.

Hmm weird. The test cases where is_palindrome was failing seemed to be passing based on the fix in this PR. What import errors are you seeing right now?