As a game initiator, I am receiving an Internal Server Error when I unselect a game then select a new game

amandaphu commented 1 year ago

Description

Next, provide a description of the issue you encountered and the outcome you expected.

[ ] Description: I thought I knew the cause but am getting inconsistent behavior. Originally, I thought the issue was around when I select a game > do not start > unselect game > select same game again. If I did the same thing but started the game, I did not get an error. However, while getting screen recordings for this ticket I experienced different things so all I know at this point is that there's some bug around unselecting games.

Screenshots/Gifs

Please provide a visual representation of the issue you encountered with screenshots or a gif. They should include the entire screen of the application, and should include the URL if the issue was found on a web app.

[ ] Screenshots or gifs:

Recording 1 select game > start > unselect game > select same game > no error x 2, then i select game > don't start > unselect game > select same game > error

Recording 2 select game > start > unselect game > select same game > error

Recording 3 select game > don't start > unselect game > select same game > no error, then select different game > don't start > select same game > no error x 2

Steps to Reproduce

Provide steps to reproduce the issue you encountered.

[ ] I am logged in as this user (leave blank if not logged in): game initiator
[ ] I am on this page: in a game
[ ] I performed these actions: select > unselect game, both before starting and after starting > reselect game
[ ] And saw this happen: received Internal Server Error

Platform/Device/Browser Information

Please provide platform, device , and browser (when applicable) that you were using when you encountered the issue.

i.e. found on iOS iPhone 7+, or found on OSX High Sierra Chrome version 37.1

[ ] Platform:
[ ] Device:
[ ] Browser (if found on web application):

nschello commented 1 year ago

Is this a specific game? I think one of the games is missing some required constraints. I uploaded a bad one on accident I think. We should definitely fix it but I am wondering if it has much to do with unselecting vs picking the game that's bad

amandaphu commented 1 year ago

Recording 1 was nicktictactoe. Recording 2 was Amanda TTT. Recording 3 was both

amandaphu commented 1 year ago

But yeah I was considering that too. Which games are good and I can try

amandaphu commented 1 year ago

i also tried with New Game Amanda which i think should be a good game (but idk) and was selecting, unselecting game (both before starting and after starting), first few tries didn't have an error but after doing it so many times, i was able to get an error.

nschello commented 1 year ago

The app is getting oom killed occasionally while unselecting/selecting over and over. I'm not sure what the culprit is at this point but we are running on the smallest size so far. I'll keep looking into it and/but it still may make sense to up the size too.

nschello commented 1 year ago

I think this has been addressed by https://github.com/extism/game_box/pull/66 and https://github.com/extism/game_box/pull/60

amandaphu commented 1 year ago

i tested this a few times, in various scenarios - select game + not start, select game + start and have not received any errors. moving to UAT

extism / game_box