extism / go-pdk

Extism Plug-in Development Kit (PDK) for Go
https://pkg.go.dev/github.com/extism/go-pdk
BSD 3-Clause "New" or "Revised" License
60 stars 11 forks source link

Test both tinygo and standard go #17

Closed egonelbre closed 1 year ago

egonelbre commented 1 year ago

This adds tests for both std go and tinygo.

It also does some project cleanup:

bhelx commented 1 year ago

You can pull my changes on .github/workflows/ci.yml to get the CI to go green.

egonelbre commented 1 year ago

@bhelx note I've rebased the code.

nilslice commented 1 year ago

Thank you!

I'm generally in favor of keeping .wasm in the repo (we always find a reason to download and use these modules) -- but not a requirement.

Would like to know what @bhelx / @zshipko prefer there before going one way or the other on committing the modules.

egonelbre commented 1 year ago

@nilslice If they need to be downloaded one option would be to make them part of a release. (Rather than part of the source code)

nilslice commented 1 year ago

Yea that's preferable -- especially since Go will pull down all of this into the system cache including the wasm.

zshipko commented 1 year ago

Having the wasm modules in the repo is convenient, but can be pretty annoying to work with in git. Moving them to a release instead is a good idea!

egonelbre commented 1 year ago

Do you want me to add the release thing in this PR or in a separate one?

bhelx commented 1 year ago

@egonelbre this looks good to me! Let's do follow ups in other PRs