search

extism / go-sdk

Extism Go SDK - easily run WebAssembly modules in your Go applications
https://pkg.go.dev/github.com/extism/go-sdk
BSD 3-Clause "New" or "Revised" License
85 stars 10 forks source link

feat: Add Observe SDK support #47

Closed mhmd-azeez closed 3 months ago

mhmd-azeez commented 11 months ago

Fixes #21

mhmd-azeez commented 11 months ago

@nilslice @bhelx While the Go SDK supports instrument_enter, instrument_exit, and instrument_memory_grow, it doesn't seem to support span_enter and its friends. Should I implement them here, or should I open a PR in the observe-sdk repo?

nilslice commented 11 months ago

@nilslice @bhelx While the Go SDK supports instrument_enter, instrument_exit, and instrument_memory_grow, it doesn't seem to support span_enter and its friends. Should I implement them here, or should I open a PR in the observe-sdk repo?

Oh yea that's right. That would be a great PR on the observe-sdk repo!

bhelx commented 11 months ago

I can add those onto the Go SDK today. I think I already have a branch for it.

bhelx commented 9 months ago

What should we do with this PR? been on my review list for a long time

nilslice commented 9 months ago

In our meeting last week we decided to let it sit until things progress with migration to wasi-observe. But if we can use it in the meantime, I'd be all for updating to the latest API and merging with some experimental note.

The biggest change in-flux that would possibly impact this is the addition of a Context parameter to the instrumentation functions.

cc/ @chrisdickinson

mhmd-azeez commented 3 months ago

@G4Vi thanks for your feedback, I think the PR is ready to be merged