search

extism / js-pdk

Write Extism plugins in JavaScript & TypeScript
42 stars 16 forks source link

Use curl instead of wget on macOS and fix Linux install instructions #2

Closed lukevp closed 1 year ago

lukevp commented 1 year ago

wget isn't installed by default on macOS. Update the script to use curl instead.

lukevp commented 1 year ago

I noticed the install instructions used wget instead of curl, which requires installation on Mac. I updated to use curl instead, and the same script should work on both macOS and Linux.

I did notice that the architecture is hardcoded to be the x86 build. Is there an ARM Mac build of Extism and of the PDK for use on M1/M2 processors?

bhelx commented 1 year ago

@lukevp we don't have an ARM build yet but would gladly take a PR for it. I'm on an M1 and I'm using the x86 one fine for now.

bhelx commented 1 year ago

Oh wait, re-reading your question, yes we do have ARM builds for extism itself: https://github.com/extism/extism/releases/tag/v0.1.0

but not for this extism-js CLI

bhelx commented 1 year ago

Just need to add a different arch to the matrix here i think? https://github.com/extism/js-pdk/blob/main/.github/workflows/publish.yml#L36

libextism does it like this: https://github.com/extism/extism/blob/main/.github/workflows/release.yml#L18