search

extism / php-sdk

Extism PHP Host SDK - easily run WebAssembly modules / plugins from PHP applications
https://extism.org
BSD 3-Clause "New" or "Revised" License
20 stars 4 forks source link

fix: Remove PHP 8.0 syntax to maintain PHP 7.4 compatibility #19

Closed oatmael closed 4 months ago

oatmael commented 5 months ago

Union return types are not supported in PHP 7.4. Thankfully, T|null is equivalent to ?T. See below: https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.nullable

mhmd-azeez commented 4 months ago

Now that #20 is merged, @oatmael can you please rebase/merge the changes into your branch?

oatmael commented 4 months ago

Now that #20 is merged, @oatmael can you please rebase/merge the changes into your branch?

Done 👍

oatmael commented 4 months ago

@mhmd-azeez poking on this - looks like the CI failed from a rate limit 😅

mhmd-azeez commented 4 months ago

Thanks a bunch, great work!