search

extism / php-sdk

Extism PHP Host SDK - easily run WebAssembly modules / plugins from PHP applications
https://extism.org
BSD 3-Clause "New" or "Revised" License
20 stars 4 forks source link

refactor: phpcs and composer related updates #21

Closed yigitcukuren closed 4 months ago

yigitcukuren commented 4 months ago

Hey there,

I know this looks huge, but as far as I can see, there are no standards in the PHP code. I thought I might add some standards to make the PHP SDK more collaborative for everyone. If you think these changes are too much, I wouldn't mind creating multiple PRs for a smoother transition.

bhelx commented 4 months ago

Thanks for taking the time to improve it! We don't mind the size of the PR. This seems to be all internal changes correct? Assuming there are no external changes then i'd consider it a simple patch / cleanup. No need to break it up.

yigitcukuren commented 4 months ago

Great job @yigitcukuren, thank you very much! Can you please go through LibExtism.php functions and try to mark as many of them private as possible?

Thank you! I have just updated the visibility of all the internal methods.

yigitcukuren commented 4 months ago

Thank you very much for your excellent work @yigitcukuren, I moved LibExtism to \Extism\Internal namespace to make it clear that this class is for internal use only. Let me know if you have any concerns or issues with that. Otherwise, I can go on and merge the PR

It is perfectly fine! Please go ahead 🙏