extism / playground

BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

feat: loading screen spinner #7

Closed bhelx closed 1 year ago

bhelx commented 1 year ago

Shows a spinning loading screen in the output while the plugin is working so that a user knows that their call was executed but a response has not come back. We could perhaps put a spinner on the Run Plugin button as well, or alternatively only put it there.

Screen Shot 2022-11-20 at 3 58 01 PM
cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 92dba4c
Status: ✅  Deploy successful!
Preview URL: https://0afa9a7c.playground-1xh.pages.dev
Branch Preview URL: https://spinner-on-load.playground-1xh.pages.dev

View logs

nilslice commented 1 year ago

Great idea - maybe it can be a little smaller? Putting in in the Run Plugin button instead is a good idea too. Swap out the text for the spinner until the plug-in call resolves?

bhelx commented 1 year ago
Screen Shot 2022-11-21 at 10 30 26 AM

Changed the design a bit. There are some issues with the layout where I can't quite center things vertically without it going off the screen. Will try to work on the layout in another PR so we can properly use flex.