search

extiverse / bazaar

The extension marketplace for your Flarum forum.
https://discuss.flarum.org/d/5151
MIT License
59 stars 14 forks source link

Drop dev dependencies #51

Open luceos opened 7 years ago

luceos commented 7 years ago

Anyone using bazaar most likely does not need any dev dependencies, let's not install those in our vendor.

clarkwinkelmann commented 7 years ago

Well, that's why they are called dev dependencies!

People should install bazaar with --no-dev / --update-no-dev flag

Bazaar itself already runs composer in production mode. (It's not clearly visible because it's the default behavior; in the official composer CLI the absence of the --no-dev flags sets the setDevMode(). Example: https://github.com/composer/composer/blob/master/src/Composer/Command/InstallCommand.php#L104)

luceos commented 7 years ago

I meant that bazaar should install packages without including dev dependencies by default. I wasn't specifically talking about installing bazaar 😁

clarkwinkelmann commented 7 years ago

It's not working then? It should :sweat_smile:

luceos commented 7 years ago

It's not about dist mode, it's about dev mode:

https://github.com/composer/composer/blob/master/src/Composer/Command/InstallCommand.php#L105

luceos commented 7 years ago

Oh that's what you said too, but doesn't composer set dev mode if left out.. Seems like it doesn't. We'd have to confirm this anyway.