Closed clarkwinkelmann closed 7 years ago
Merging #68 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 29.27% 29.28% +0.01%
==========================================
Files 43 43
Lines 919 1055 +136
==========================================
+ Hits 269 309 +40
- Misses 650 746 +96
Impacted Files | Coverage Δ | |
---|---|---|
src/Composer/Commands/RequireCommand.php | 88.88% <0%> (-2.78%) |
:arrow_down: |
src/Composer/ComposerEnvironment.php | 85.41% <0%> (-2.09%) |
:arrow_down: |
src/Composer/Utils/ComposerFileEditor.php | 92.1% <0%> (-1.65%) |
:arrow_down: |
src/Composer/Utils/JsonManipulator.php | 40.65% <0%> (-1.11%) |
:arrow_down: |
src/Composer/Commands/BaseCommand.php | 92.3% <0%> (-1.03%) |
:arrow_down: |
src/Api/Controllers/UpdateExtensionController.php | 0% <0%> (ø) |
:arrow_up: |
src/Events/ExtensionWasUpdated.php | 0% <0%> (ø) |
:arrow_up: |
src/Listeners/AddClientAssets.php | 0% <0%> (ø) |
:arrow_up: |
...c/Api/Controllers/UninstallExtensionController.php | 0% <0%> (ø) |
:arrow_up: |
src/Jobs/ComposerJob.php | 0% <0%> (ø) |
:arrow_up: |
... and 26 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca37e6b...fb9b627. Read the comment docs.
I've pushed a change that handles the size aspect. Can you review and merge this if agreed on @clarkwinkelmann ?
Looks fine.
I added the suggested issue tracker link:
I also checked this PR against beta7, everything seems fine. I'm merging
Fixes #67