search

extiverse / bazaar

The extension marketplace for your Flarum forum.
https://discuss.flarum.org/d/5151
MIT License
59 stars 14 forks source link

Failed to clone #75

Closed SamB440 closed 7 years ago

SamB440 commented 7 years ago

Hi, I have an issue when trying to uninstall / install / update an extension. It seems that it tries to clone from github and fails.

Steps to reproduce

  1. Go to admin
  2. Open bazaar tab
  3. Try to uninstall / install / update and you will get this error

Expected behaviour

It should update / install / uninstall.

Actual behaviour

I get an error. Oops! Something went wrong. Please reload the page and try again. This happens on any extension. It doesn't even seem to be trying to clone from the extension I'm actually updating / installing / uninstalling.

Configuration

Version of Bazaar: 0.2.2 Version of Flarum: Beta 6

**Logs**: Failed to clone https://github.com/Cl1608Ho/flarum-ext-discord-webhook.git, git was not found, check that it is installed and in your PATH env. sh: git: command not found
clarkwinkelmann commented 7 years ago

Hi, thanks for your report.

Can you share the content of your composer.json file and your composer version (via composer --version) ?

SamB440 commented 7 years ago

Composer.json: { "name": "flarum/flarum", "description": "Delightfully simple forum software.", "type": "project", "keywords": ["forum", "discussion"], "homepage": "http://flarum.org", "license": "MIT", "authors": [ { "name": "Toby Zerner", "email": "toby.zerner@gmail.com" }, { "name": "Franz Liedke", "email": "franz@develophp.org" } ], "support": { "issues": "https://github.com/flarum/core/issues", "source": "https://github.com/flarum/flarum", "docs": "http://flarum.org/docs" }, "require": { "flarum/core": "^0.1.0", "flarum/flarum-ext-akismet": "^0.1.0", "flarum/flarum-ext-approval": "^0.1.0", "flarum/flarum-ext-auth-facebook": "^0.1.0", "flarum/flarum-ext-auth-github": "^0.1.0", "flarum/flarum-ext-auth-twitter": "^0.1.0", "flarum/flarum-ext-bbcode": "^0.1.0", "flarum/flarum-ext-emoji": "^0.1.0", "flarum/flarum-ext-english": "^0.1.0", "flarum/flarum-ext-flags": "^0.1.0", "flarum/flarum-ext-likes": "^0.1.0", "flarum/flarum-ext-lock": "^0.1.0", "flarum/flarum-ext-markdown": "^0.1.0", "flarum/flarum-ext-mentions": "^0.1.0", "flarum/flarum-ext-pusher": "^0.1.0", "flarum/flarum-ext-sticky": "^0.1.0", "flarum/flarum-ext-subscriptions": "^0.1.0", "flarum/flarum-ext-suspend": "^0.1.0", "flarum/flarum-ext-tags": "^0.1.0", "flagrow/bazaar": "^0.1.0", "cl1608ho/flarum-ext-discord-webhook": "^0.1.0@beta", "flagrow/upload": "^0.5.7", "sijad/flarum-ext-links": "^0.1.0@beta", "xengine/flarum-ext-signature": "^0.1.2", "ganuonglachanh/flarum-ext-markdown-editor": "^0.9.0", "hugogit/flarum-ext-discordwidget": "^0.1.7", "flagrow/byobu": "^0.1.0@beta", "datitisev/flarum-ext-dashboard": "^0.1.0@beta", "jordanjay29/flarum-ext-summaries": "^0.2.0" }, "require-dev": { "franzl/studio": "^0.11.0" }, "config": { "preferred-install": "dist" }, "minimum-stability": "beta", "prefer-stable": true } Composer version: 1.4.1

luceos commented 7 years ago

@clarkwinkelmann i think the issue is that composer will fall back on doing a git checkout/clone in case no dist tarball was found. There might be several reasons for that, but none we have any influence on. I guess we need to start working on our own dist files directory. 😬

clarkwinkelmann commented 7 years ago

@luceos i think the issue is that composer will fall back on doing a git checkout/clone in case no dist tarball was found

That's what I believe as well.

@SamB440 I installed a Flarum just like yours based on the composer file and I can't reproduce the issue. This must be something with your environment.

I may suggest you try to clear composer cached files. A thing that happened to me in the past was the cache was written with wrong permissions and everytime composer ran it was fetching things again in a different manner.

@luceos I guess we need to start working on our own dist files directory

Wouldn’t we end up hitting the same kind of issues with our own implementation ? :thinking:

SamB440 commented 7 years ago

I tried clearing the cache and the issue still occurs :(

clarkwinkelmann commented 7 years ago

Seeing you have "config": { "preferred-install": "dist" } in your composer.json there's no reason for composer to try downloading the source code...

I'm running out of suggestions. If you are able to install git on your server, you could at least use Bazaar, even if it fetches the source instead of the dist.

luceos commented 7 years ago

What composer version is installed @SamB440 ?

SamB440 commented 7 years ago

1.4.1, as stated before :P It's pretty recent, not that old.

luceos commented 7 years ago

Sorry I missed that :grin: I also think your cache folder is not writable. Can you run the action bazaar tries manually?

composer require flagrow/upload -vvv
clarkwinkelmann commented 7 years ago

@SamB440 is this still happening ? Did you try @luceos suggestion ?

I'm closing this because it's clearly not a Bazaar issue. Feel free to come back with additional information. I'll re-open if necessary :wink: