extiverse / bazaar

The extension marketplace for your Flarum forum.
https://discuss.flarum.org/d/5151
MIT License
59 stars 14 forks source link

Check whether removing flushCacheKey has an effect #76

Open clarkwinkelmann opened 7 years ago

clarkwinkelmann commented 7 years ago

While implementing the search feature, I removed an unwelcomed call to flushCacheKey that was clearing the whole extension cache on each request, making the search extremely slow.

https://github.com/flagrow/bazaar/pull/73#discussion_r129978221

That method call was undocumented. From @luceos words:

@luceos A drawback of removing this line all together is an issue caused when we add an extension to the UX that wasn't received from Flagrow.io but is installed.

But I can't reproduce the issue. If a package isn't available in flagrow.io, it simply doesn't show in Bazaar page, with or without a call to flushCacheKey... :neutral_face: