Closed clarkwinkelmann closed 6 years ago
Merging #83 into master will decrease coverage by
0.73%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 28.87% 28.14% -0.74%
==========================================
Files 43 45 +2
Lines 1070 1098 +28
==========================================
Hits 309 309
- Misses 761 789 +28
Impacted Files | Coverage Δ | |
---|---|---|
src/Repositories/ExtensionFactory.php | 0% <0%> (ø) |
|
src/Repositories/ExtensionRepository.php | 0% <0%> (ø) |
:arrow_up: |
src/Repositories/ExtensionCacheRepository.php | 0% <0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 38c6b15...76fd071. Read the comment docs.
By the way, this fixes #76 by completely removing the old code that used it.
Closing in on being a year old @clarkwinkelmann. Closing.
Refactored the ExtensionRepository into 3 classes:
Also renamed a bunch of variables in ExtensionRepository, their naming was very confusing.
There are probably still improvements to do. But I think it's already a lot cleaner.
It's now possible to update only part of the cache. It's used for the favorite feature and I plan to use it for premium extension state as well in #66