Closed WetHat closed 4 months ago
This library removes advertising parameters from URLs, while preserving all other parameters intact. If you are not a marketer, it should be fine :dancers:
Here's a list of parameters targeted for removal:
https://github.com/extractus/feed-extractor/blob/main/src/utils/linker.js#L21
@ndaidong Thanks for the feedback. No, I'm not a marketeer , so removing advertising parameters is fine with me :-) However, local link targets (see second example) seems a bit too much.
@WetHat I see, the local link targets you mentioned is hash property in URLs. While they can be useful for scrolling to specific sections, we're removing them with purify() method. This is because feed entries should ideally link to entire articles, not just a specific part.
@ndaidong I completely agree with your point that feed entries should ideally link to entire articles, not just to specific sections. I've seen a fair share of really weird interpretations of the RSS idea where feed items were pointing to sections inside a large log like article. However, these are corner cases. Sticking with purify() sounds acceptable.
The extractor removes the query part of links like (see attached feed and example below):
is returned as
and also local link targets:
is returned as
While in this case the query is not essential, for other feeds it is. The missing local target may be a usability issue for large articles. Hence the link should always be returned in its complete form.
feed.zip