search

extrame / xls

Pure Golang xls library
Apache License 2.0
329 stars 207 forks source link

FIX: fixed data reading errors #48

Closed sergeilem closed 5 years ago

sergeilem commented 6 years ago

Fixed data reading from big files. Improved "continue" handling. Also test with big table added. Related to #31, #46. May be solving these issues.

alialamine commented 6 years ago

Had the same problem and I tested this and it works. Should be merged.

alialamine commented 6 years ago

btw @sergeilem , you don't need to put your email and FIX as comments, git saves all that info with the commits. Eventually the code becomes full of such comments and that becomes annoying (hence why git saves them separately for when they need to be checked)

sergeilem commented 6 years ago

OK @alialamine, i removed FIX and email from comments, thank you

alialamine commented 6 years ago

@sergeilem Careful with this fix, just discovered instances where it actually gives wrong output (cells on wrong rows, merging two rows, etc). While it fixes the issue of the data missing, it corrupts some of it.

sergeilem commented 5 years ago

@alialamine, can you give me sample file? I'll try to fix it.

sergeilem commented 5 years ago

More analysis needed, closing.