search

extrapixel / gif-animation

GifAnimation is a Processing library to play and export GIF animations
GNU General Public License v3.0
171 stars 38 forks source link

Looking for maintainer / project owner #18

Open extrapixel opened 5 years ago

extrapixel commented 5 years ago

@01010101 @cgiles @jimcavoli @aib

extrapixel commented 5 years ago

@villares @bryant1410

aib commented 5 years ago

I don't think I would be the right person because I've only ever used the library a few times and I'm not really a processing user.

But I wonder if simply giving people commit access would help. https://felixge.de/2013/03/11/the-pull-request-hack.html

hamoid commented 5 years ago

I might be able to maintain it... I'm the author of the VideoExport library for Processing and I combined several C GIF libraries last year for improved quantization.

The only thing is that I'm slightly busy atm. Is there much work to be done currently? Maybe make the 3.0 branch the default?

extrapixel commented 5 years ago

@hamoid I think the 3.0 branch pretty much works as is - first thing would be to publish it so folks can use it again via the "new" processing library distribution method(s).

hamoid commented 5 years ago

So I volunteer to keep it running and respond to issues and PRs, basically, do maintenance work. Maybe you want to wait and see if there's different "candidates" and what is their expertise? Should anything be discussed via e-mail?

extrapixel commented 5 years ago

That's great @hamoid , I've added you as a collaborator. If more interested people show up, I will add them too. Let's see how that goes, before we do the owner transfer. For openness and transparency I'd prefer to continue all communication here instead of email. Does that work for you?

First things would be to test the 3.0 branch - maybe check/fix open issues for 3.0. People say it woks, so there's probably not much to be done, except formalising a new release for the Processing IDE library manager. Another thing is to bring stuff from 3.0 branch to master and github pages.

jeremydouglass commented 5 years ago

I could help with testing.

I personally think releasing 3.0 branch as default could be done immediately after confirming that the examples work in PDE 3.x -- and then later track down whether #13 is still an issue and how to fix.

If more people are using gifAnimation via Contributions manager and become familiar with it again then the pool of potential contributors should also increase.

hamoid commented 5 years ago

Thank you :) I'll compile the library locally and test on 3.0. I'm fine with discussing everything here.

hamoid commented 5 years ago

Funny question: how do you build the library? I don't see any of the files from the library template there (resources/, build.xml, build.properties). I can add those myself, but I was just wondering how do you do it @extrapixel ?

GoToLoop commented 5 years ago

How do you build the library?

I've just taken a quick look inside the 4 ".java" files of this library. This library only imports the vanilla Java classes and some Processing classes. Should be pretty easy to compile them all even manually by using just the "javac" command line.

extrapixel commented 5 years ago

@hamoid, yes @GoToLoop is right, it will compile in the command line using javac without problems. I followed this information back then: https://github.com/processing/processing/wiki/Library-Basics

I agree @jeremydouglass . Would be great if you could you test branch 3.0 and also check wether the installation procedure described in the 3.0 branch readme is correct and works.

hamoid commented 5 years ago

Thanks @extrapixel that link helped (I always run an ant script to build my library). This is what I did:

javac -source 1.6 -target 1.6 -d . -classpath /usr/share/processing/core/library/core.jar src/*.java
jar -cf gifAnimation.jar gifAnimation

The first command creates a gifAnimation folder with the .class files, the second command makes the jar out of those .class files.

I'll test the jar tomorrow.

extrapixel commented 5 years ago

alright! also, feel free to create new dev branch, including the jar etc, so the others can use your version to test.

hamoid commented 5 years ago

Today I tested the produced jar file with the latest Processing and both examples worked fine (display gif and export P3D to gif). I'll create the dev branch tomorrow :)

AlvaroHermida commented 5 years ago

I tested the dev branch on Windows 10 Edu 64bit, and everything works fine. Now all the issues (including #13) are solved. I think the only pending work is just to comply with the advertising protocol before contacting the Processing Librarian Elie Zananiri to restore access from the Processing IDE.

Pending tasks:

By the way, it could be the right time to update the page http://extrapixel.github.io/gif-animation/ , and to patch the broken link http://www.extrapixel.ch/ on the "GifAnimation" entry on https://processing.org/reference/libraries/

I volunteer to help @hamoid on this final tasks, if necessary.

AlvaroHermida commented 5 years ago

The PR #21 tries to simplify the promotion of the current dev branch for advertising on the Processing IDE. After merging both on the master branch it is necessary to check if the following url's works (they depend on the merged contents):

...and we will be ready to contact Elie Zananiri.

hamoid commented 5 years ago

Thank you for the help @AlvaroHermida ! :) I will take a look at this in the next days. Happy end of year!

extrapixel commented 5 years ago

Hi @AlvaroHermida , thank you very much! I'v added you as a collaborator - if you want, please go ahead with the merging.

AlvaroHermida commented 5 years ago

Thanks! I think we may wait a few days to enjoy the New Year's Eve and polish some details (particularly the final url's, since they may change to something like "https://github.com/extrapixel/gif-animation/blob/3.0/gifAnimation.txt" after changing the default branch).

In fact, I still need to understand why the url https://github.com/extrapixel/gif-animation/archive/3.0.zip works, while I cannot access the archive folder from the web interface. Any hint will be appreciated.

Happy end of year!

AlvaroHermida commented 5 years ago

Sorry, I clicked the wrong button... ("Close and comment" instead of "Comment")

extrapixel commented 5 years ago

Any hint will be appreciated.

It's the link that is provided by the GitHub website: screen shot 2018-12-30 at 14 51 38

AlvaroHermida commented 5 years ago

Thanks again!

So, since we need to host the .txt and the .zip on the same static folder, these files will need manual updating on every new release.

You will need to provide a static link to the latest version of your library, and host a copy of your library.properties alongside it. The result on your server should look something like this:

http://www.example.com/awesomelib.zip (The latest version of awesomelib) http://www.example.com/awesomelib.txt (A copy of the library.properties file contained in awesomelib.zip) ... On our end, we'll only record the location of awesomelib.txt, and we'll assume that a copy of the library file is hosted at an address by the same name, except ending in zip

I have updated #21 accordingly, to use the following url's

I'll go now to standby mode 😴 until @hamoid checks the PR. See you next year!

hamoid commented 5 years ago

Should we host those two files in a GitHub Page? I think only @extrapixel can enable that feature, if desired. It looks something like this: 2019-01-04-145608_792x434_scrot We could choose docs/ and then commit into that folder the binary and the txt file. Any time we update those files in the repo, they should become available in the Library Manager in the PDE. What do you think?

extrapixel commented 5 years ago

@hamoid GitHub pages are currently in the gh-pages-branch: https://github.com/extrapixel/gif-animation/tree/gh-pages

Do you want it to move to the docs folder?

hamoid commented 5 years ago

Ah, I didn't know it was set up already. It's visible at https://extrapixel.github.io/gif-animation/

We only need to post the zip and the txt to that repo, right?

extrapixel commented 5 years ago

We only need to post the zip and the txt to that repo, right?

That should work. We could also have a distribution folder within the master branch to host these files directly in the repo: https://github.com/extrapixel/gif-animation/raw/master/distribution/gifAnimation.zip https://github.com/extrapixel/gif-animation/raw/master/distribution/gifAnimation.txt

This could make the release/update process a tad easier.

AlvaroHermida commented 5 years ago

Yes, the ./raw/master/distribution trick will facilitate future updates, assuming it qualifies as "static link" for the Contribution Manager updating script. Thanks for the info, @extrapixel!

I have edited again the README.md file to reflect the new repository address, and I have created and populated the distribution folder (both in patch-1 and in master, just in case).

The next steps after @hamoid greenlights the latest changes are just to merge #21, change the default branch, and write to the librarian. If you want to delegate this tasks, just tell me :) .

hamoid commented 5 years ago

Hi! Sorry for the delay... I went for a long trip and it slipped my mind. I tried the download link from your README, installed it and both examples work fine in Linux. Green light on my side :)

extrapixel commented 5 years ago

@AlvaroHermida from my point of view, you can proceed with the merging etc. Thanks!!!!

jimcavoli commented 5 years ago

Thanks for thinking of me; I've really not done much with the project recently, so I think I'm probably better left as just a contributor for now, but thanks for the nod. It sounds like some of the fine folks here have things covered. Should that change and the need arise again, I'd be happy to reconsider in the future.

ppgutkus commented 5 years ago

when I call myAnimation = new Gif(this, "http://i.imgur.com/jzdE0zY.gif"); from external server the gif will loaded just around 2 sec and missing a lot of frame.

extrapixel commented 5 years ago

What's holding us back to continue with the merging etc?

hamoid commented 5 years ago

I think I (mis?)read "If you want to delegate this tasks, just tell me :)" and assumed @AlvaroHermida would change the branch.

I can do this next week, unless someone wants to do that earlier :) (several coming gigs this week)

hamoid commented 5 years ago

Lets do this :) I read above these are the pending tasks

jeremydouglass commented 3 years ago

At this point can #21 be merged and this be resolved?

hamoid commented 3 years ago

Hi @jeremydouglass

I can click the merge button, but I don't have time to verify that the 3 points I listed above are the right steps to take nor to verify the PR. Would it work if you open a discussion in the forum with the goal of verifying the PR and deciding the next steps (default branch, URLs to the library) and I do whatever is decided? I don't know who else has access to this repo, I guess I'm not the only one who can merge the PR?

n1ckfg commented 2 years ago

Seems like the current (3/4) Processing library manager still sees the Processing 2 version...animated GIF experiments are always a hit with my students; can I do anything to help move this along?

extrapixel commented 2 years ago

@hamoid, i've merged @AlvaroHermida 's old PR #21 , made 3.0 the default branch and merged the dev branch into it.

So, I think we are ready to serve the libs at

extrapixel commented 2 years ago

I have contacted the librarian Elie Zananiri a couple of days ago but haven't heard back. I assume the library manager will soon see the new version. I also asked to fix the links on the processing library page.

@n1ckfg if you want to chime in on #31 that would certainly help to move this along