search

extrawurst / DerelictImgui

Dynamic bindings to the cimgui library (a c-api for IMGUI) for the D programming language
MIT License
54 stars 13 forks source link

Update the API to follow cImGui v1.53.1 #18

Closed lenormf closed 6 years ago

lenormf commented 6 years ago

I've started the work to migrate to v1.53.1, I could successfully run the demo using this patch. Comparisons between what's supported by cimgui and this implementation of the bindings will probably have to be made, in order to avoid blindspots (some things might not be supported yet).

Closes #17.

extrawurst commented 6 years ago

can you update this branch to the latest PR being merged, so that we can see travis running through successfully?

lenormf commented 6 years ago

Done!

extrawurst commented 6 years ago

Here we go, its green. You did not update cimgui (the submodule) to the version you made it compatible with, right? Can you do that, then we are awesome :) You can also update the readme to reflect the version.

lenormf commented 6 years ago

I'm waiting to make sure that the entire API is being correctly bound. I might do it, just not sure when. Once that's done, I'll add a commit to update the README and the submodules' configuration.

extrawurst commented 6 years ago

ok then I'll keep this PR open until then. the submodule should reflect the version used here. Thanks already in advance for your big help!

lenormf commented 6 years ago

I finished migrating the demo to have a 1:1 equivalence with the C++ one. There might still be some uncovered bugs somewhere (e.g. API changes from the C bindings), but I think most of the work is done now.

The build error is due to a network error on Travis' side, the build probably works on gdc (haven't tested).

extrawurst commented 6 years ago

Thanks so much! lgtm

lenormf commented 6 years ago

Will you update the dub package to this version?

extrawurst commented 6 years ago

done: https://github.com/Extrawurst/DerelictImgui/releases/tag/v0.10.0