search

extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.5k stars 571 forks source link

Freeze when `Blame` inside a `Blame` #1336

Closed AndyJado closed 2 years ago

AndyJado commented 2 years ago

Describe the bug

My working repo is rust from rust-lang, I go <Shift-B> on a file from another commit and I see some spinning, then spinning goes off and freeze, I can esc to go back.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Files'
  2. 'Blame'
  3. Inspect that commit 'l'
  4. Go to 'Files' with <Shift + f>, head in another commit now
  5. Blame again on anyfile
  6. freeze!

Expected behavior

Maybe forbid recursively blaming?

Additional context

If it's not a hurry, I'd like to fix it. I'm currently rather loaded

extrawurst commented 2 years ago

can't reproduce. can you give me exact files you blame to get this to happen?

AndyJado commented 2 years ago
  1. Go to 'Files' with <Shift + f>, head in another commit now
  2. Blame again on anyfile

sorry I wasn't clear, modified step 4.

I tested it on much smaller repo, it happens.

extrawurst commented 2 years ago

still no repro inside gitui repo. can you trigger it in the gitui repo?

chenrui333 commented 2 years ago

Yeah, I am unable to reproduce either in a small repo.

But I do see gitui runs blame pretty slow for me compared with gitlens (vscode) in the monorepo setup.

extrawurst commented 2 years ago

@chenrui333 yeah the blame slowness in some cases is in another issue already

AndyJado commented 2 years ago

Gone after upgrade, my bad.

package gitui v0.20.1 with `gitui v0.21.0