search

extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.5k stars 571 forks source link

Some colors inverted on highlight, not all. #1365

Closed gb-papercut closed 2 years ago

gb-papercut commented 2 years ago

Thanks for gitui! Wow, so many years of using git from the CLI because I could never find a UI that I liked. Great work.

I noticed some colours get inverted on selection highlight. For example, the default black text turns to white:

image

Others, don't get inverted, like this one:

image

This makes it difficult to pick a selection_bg that works for all cases.

Both iTerm2 and Terminal on macos display this behavior.

gb-papercut commented 2 years ago

This issue talks about setting the colors in iTerm2's theme to get everything right, but I think that's a bit different than my issue of "sometimes inverting" selections.