search

extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.59k stars 573 forks source link

improper background color patterns when scrolling file content #1551

Open unixoidal opened 1 year ago

unixoidal commented 1 year ago

In the "Files [3]" I am trying to view the content of the files. When scrolling some background colors are not updated and a green-pink mess is seen. Unfortunately, I cannot attach the full screenshot due to private owned code. But please see the right side of guiui window where color glitches are seen.

OS/Distro: Debian 11 (Bullseye), Linux deb-ak 5.10.0-19-amd64 #1 SMP Debian 5.10.149-2 (2022-10-21) x86_64 GNU/Linux Terminals used where issue is observed: -- MATE Terminal -- xterm Rust version: 1.48 GitUi version: 0.22.1

image

extrawurst commented 1 year ago

never seen those. would be good to get a reproducible case of this

unixoidal commented 1 year ago

Let me know please how to turn on the debug/logs so I could provide more info.

extrawurst commented 1 year ago

https://github.com/extrawurst/gitui#diagnostics

cycle2zhou commented 1 year ago
image image

There is a very serious color crash, resulting in a lot of content is basically unviewable

cycle2zhou commented 1 year ago

It is tested that this problem only exists in the native terminal of macos, and iterm2 and vscode do not have this problem

extrawurst commented 1 year ago

works for me on the native macOS terminal:

Screenshot 2023-08-10 at 12 54 04
cycle2zhou commented 1 year ago

The files TAB has a higher probability of appearing, which is a few random occurrences, and I generally look at a few more files

cycle2zhou commented 1 year ago

After the Show ANSI colors feature is turned off, there are no scrambled colors, but the selected colors cannot be seen

extrawurst commented 1 year ago

can't reproduce.

maybe you can checkout a few other tui apps that use the same framework I do to see if they behave weird aswell: https://github.com/ratatui-org/ratatui/wiki/Apps-using-Ratatui

cycle2zhou commented 1 year ago

gitui.log

https://github.com/extrawurst/gitui/assets/33155330/48c9880a-4664-4cfb-8605-446536984de6

Above is the log and replay video to see if it helps

extrawurst commented 1 year ago

See above regarding other tools to compare please

cycle2zhou commented 1 year ago

I tried bottom, bandwhich, gping, and nothing like gitui

extrawurst commented 1 year ago

No idea :(

stale[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.