extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.26k stars 555 forks source link

When entering Chinese information, the pop-up window does not follow the cursor #1699

Open oriming opened 1 year ago

oriming commented 1 year ago

Describe the bug When entering Chinese information, the pop-up window does not follow the cursor.

To Reproduce Steps to reproduce the behavior:

  1. Commit
  2. Enter submission information

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

https://github.com/extrawurst/gitui/assets/61300279/63c3b4f3-16ce-42d3-8f33-76b8c7358116

extrawurst commented 1 year ago

is that only the case for Chinese?

oriming commented 1 year ago

@extrawurst This is a program bug and has nothing to do with the language.

eclairevoyant commented 1 year ago

I can reproduce on Linux with other languages. The issue is the IME candidate input or candidate list should be aligned to the cursor, but in gitui it bounces between aligning to the bottom right corner of the modal and the top left of the app itself.

I assume this is not an upstream issue because other ratatui-based programs I tested (ttyper, systeroid) don't appear to have this behavior

extrawurst commented 6 months ago

is that still an issue with 0.25 and the new textarea implementation?

ZCShou commented 6 months ago

is that still an issue with 0.25 and the new textarea implementation?

Yes. I tested in windows terminal on windows 11 and ubuntu 20.04 , see the following picture.

image