Cannot commit with empty e-mail.

Densaugeo commented 3 months ago

Describe the bug When git is configured with an empty e-mail address, gitui does not allow commits.

To Reproduce Steps to reproduce the behavior:

git config --global user.email "<>"
git init foo
cd foo
echo "some content" > a_file.txt
gitui
# Stage a_file.txt
# Hit "c" to start a commit
# Type any commit message and hit enter

Expected behavior A new commit should be created.

Screenshots

Context (please complete the following information):

Fedora 39
GitUI 0.24.3
Git 2.44.0

extrawurst commented 3 months ago

That is literally not an empty string 😂

pretty sure that’s an upstream issue in libgit2

Densaugeo commented 3 months ago

For some reason, I though git didn't allow actual empty strings and used <> to represent them. Not sure where I got the idea.

Anyway, I did a quick test with email = in my .gitconfig file, and I got a similar error message:

extrawurst / gitui

Cannot commit with empty e-mail. #2178