extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.64k stars 573 forks source link

Use default shell instead of bash on Unix-like OS #2343

Closed yerke closed 3 months ago

yerke commented 3 months ago

This Pull Request fixes/closes #2317.

It changes the following:

Why we need it? macOS uses zsh by default now.

I followed the checklist:

yerke commented 3 months ago

@extrawurst @mtsgrd Do you mind taking a look? Thanks.

extrawurst commented 3 months ago

I suggest you run make check locally - it will run everything the CI runs (and currently fails)

yerke commented 3 months ago

@extrawurst thanks for letting me know. It passes now locally. Edit: I think it needs your approval to run the checks again in CI.

extrawurst commented 3 months ago

@yerke thank you for your contribution ❤️