extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.64k stars 573 forks source link

nightly panics when gitui opens from a repo's subdirectory, on Log tab #2358

Closed doums closed 2 months ago

doums commented 2 months ago

Describe the bug

On a repo (nymtech/nym-vpn-client), when I open gitui from a subdirectory and the Log tab is selected it panics. Note it works as expected when I open it from repo's root.

GitUI was close due to an unexpected panic.
Please file an issue on https://github.com/extrawurst/gitui/issues with the following info:

PanicHookInfo { payload: Any { .. }, location: Location { file: "asyncgit/src/revlog.rs", line: 186, col: 14 }, can_unwind: true, force_no_backtrace: false }
trace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>

GitUI was close due to an unexpected panic.
Please file an issue on https://github.com/extrawurst/gitui/issues with the following info:

Any { .. }
trace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>

fish: Job 1, 'gitui' terminated by signal SIGABRT (Abort)

To Reproduce Steps to reproduce the behavior:

  1. clone nymtech/nym-vpn-client
  2. cd nym-vpn-x
  3. gitui
  4. switch to Log tab
  5. it panics

Context (please complete the following information):

extrawurst commented 2 months ago

@cruessler I thought we had fixed that. did something change with a recent gix-path upgrade?

KiranWells commented 2 months ago

Seeing the same issue on one of my repos. Context:

cruessler commented 2 months ago

@extrawurst It seems we haven’t merged the PR that fixes the issue yet. :-) https://github.com/extrawurst/gitui/pull/2301 (I haven’t double-checked the PR again, so I don’t know whether we want to make further changes.)

extrawurst commented 2 months ago

closed via #2301 - will trigger a nightly build soon