Closed wugeer closed 1 month ago
Thanks for looking into this. The gitui idiomatic way to show progress on a vertical scroll though is using a scrollbar. so I would suggest we integrate that here too. feel free to join our discord to discuss there things upfront in the future to not waste any effort.
In my personal view, having a percentage-based progress might make it a bit easier to understand. :) It seems that when scrolling up and down on this page, I didn’t notice a scrollbar on the right side. Also, I’ll create a Discord account a bit later.
@extrawurst I'll try to add a scrollbar on the right, similar to the one in a browser.:)
Browser?
Just use the same code we use everywhere else do scroll bars in for example the log tab
Yes, I will try it. :)
@extrawurst Have Done!
looking good! i wonder why you have different formatting - lets see what the ci says about that
edit: it fails on the formatting. please make sure to use the latest rust stable
My bad, my local environment was on an unstable version. I switched to the stable version of Rust, and cargo clippy works fine.
Thanks for your contribution
It changes the following:
I followed the checklist:
make check
without errorsbefore gitui_help_popup_before.webm
after gitui_help_popup_after.webm