extrawurst / gitui

Blazing 💥 fast terminal-ui for git written in rust 🦀
MIT License
18.63k stars 573 forks source link

feat: help popup display viewing progress #2388

Closed wugeer closed 1 month ago

wugeer commented 1 month ago

It changes the following:

I followed the checklist:

before gitui_help_popup_before.webm

after gitui_help_popup_after.webm

extrawurst commented 1 month ago

Thanks for looking into this. The gitui idiomatic way to show progress on a vertical scroll though is using a scrollbar. so I would suggest we integrate that here too. feel free to join our discord to discuss there things upfront in the future to not waste any effort.

wugeer commented 1 month ago

In my personal view, having a percentage-based progress might make it a bit easier to understand. :) It seems that when scrolling up and down on this page, I didn’t notice a scrollbar on the right side. image Also, I’ll create a Discord account a bit later.

wugeer commented 1 month ago

@extrawurst I'll try to add a scrollbar on the right, similar to the one in a browser.:)

extrawurst commented 1 month ago

Browser?

Just use the same code we use everywhere else do scroll bars in for example the log tab

wugeer commented 1 month ago

Yes, I will try it. :) image

wugeer commented 1 month ago

@extrawurst Have Done!

extrawurst commented 1 month ago

looking good! i wonder why you have different formatting - lets see what the ci says about that

edit: it fails on the formatting. please make sure to use the latest rust stable

wugeer commented 1 month ago

My bad, my local environment was on an unstable version. I switched to the stable version of Rust, and cargo clippy works fine.

extrawurst commented 1 month ago

Thanks for your contribution