search

exuanbo / codemirror-toolkit

A batteries-included toolset for efficient development of CodeMirror 6 based editors (w/wo React).
MIT License
15 stars 0 forks source link

Examples need updating #1

Open Andrew-Chen-Wang opened 3 weeks ago

Andrew-Chen-Wang commented 3 weeks ago

https://github.com/exuanbo/codemirror-toolkit/blob/5554f9fb0d15f985e974b76e45af8f0a1c9395a4/examples/react/with-update-listener/src/App.tsx#L31

should rewrite to include the required first of two arguments, the code mirror instance

exuanbo commented 3 weeks ago

Hook useViewEffect created by create already has the first argument bound to the CodeMirror Instance.

Screenshot 2024-10-30 at 09 55 11

https://github.com/exuanbo/codemirror-toolkit/blob/5554f9fb0d15f985e974b76e45af8f0a1c9395a4/packages/react/src/create.ts#L5-L12

This is not clear in the doc.