search

exx8 / differential-diffusion

336 stars 17 forks source link

Update requirements.txt to resolve installation issues #5

Open EtienneDosSantos opened 4 months ago

EtienneDosSantos commented 4 months ago

@exx8

exx8 commented 4 months ago

First of all thank you twice! First for the feedback and second for the PR. I will review it soon. Thank you again!

exx8 commented 4 months ago

Sorry for the delay. First the requirements.txt you suggest seems to be better, and the install scripts are a great addition! I am not sure why we need torchaudio, also IF requires SentencePiece, so I think to add it to the requirements. What do you think? Thanks! Again sorry for the delay it was very busy weekend.

EtienneDosSantos commented 4 months ago

Thx for the review! You're right; sentencepiece is necessary for IF. I've added it to 'requirements.txt' and removed the nonsensical torchaudio from both installation scripts. 😅

After committing these minor changes, I tested all models. Everything worked fine except for IF. In Stage 3, IF loads 'stabilityai/stable-diffusion-x4-upscaler/unet/diffusion_pytorch_model.bin', which my antivirus flagged as infected with 'Trojan.Ciusky.CryptedAit.1'. It's also odd that diffusers chose this file over the available safetensors variant, as it usually prefers safetensors. While this could be a false positive, it's definitely best to err on the side of caution and not use IF until this is sorted out.

exx8 commented 3 weeks ago

Hi,

I'm sorry for the delayed response. I'm currently going through a demanding period.

If it's okay, I will use your suggestions in the future once I have the capacity to maintain the repo.

Thanks for your patience.

EtienneDosSantos commented 3 weeks ago

Hey :)

No worries at all! I can assure you there is zero pressure from my side 🤗