exyte / Macaw

Powerful and easy-to-use vector graphics Swift library with SVG support
MIT License
6.02k stars 556 forks source link

Native Image Scale #781

Closed hotbott closed 2 years ago

hotbott commented 2 years ago

toNativeImage() creates a blurry image on Retina devices.

According to the reference The scale factor to apply to the bitmap. If you specify a value of 0.0, the scale factor is set to the scale factor of the device’s main screen.

Adressing issues #752, #686 and PRs #780, #748

hotbott commented 2 years ago

@ystrot, @f3dm76 please review

hotbott commented 2 years ago

is this project still active?

gunhansancar commented 2 years ago

@hotbott Thanks for the PR. I wish the owners accept the changes soon, as I tried to create the same functionality without this PR but most of the used classes are not open so stuck for now. Maybe I can add this as a static framework 🤷

VineFiner commented 2 years ago

@f3dm76 please review

VineFiner commented 2 years ago

@ystrot, @f3dm76 please review

Hello, is this default Scale 0.0 suitable?

ystrot commented 2 years ago

Looks like it's even better than previous value = 1 : https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho

VineFiner commented 2 years ago

Looks like it's even better than previous value = 1 : https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho

Okay thank you.