search

exyte / fan-menu

Menu with a circular layout based on Macaw
MIT License
728 stars 58 forks source link

Add Cartfile and remove carthage copy phase #29

Closed zocario closed 5 years ago

zocario commented 5 years ago

Add explicit dependencies using Cartfile so Carthage can detect Macaw dependency when bootstraping / updating.

Remove copy framework phase of Carthage as it should be added in the final Application using frameworks, not the library itself. This copy phase of Macaw was leading to have twice the framework in final App.

zocario commented 5 years ago

@amarunko I've made a better diagnostic of the issue described in https://github.com/exyte/fan-menu/issues/21. In fact the issue was just that a Carthage copy phase was present in the library, when this copy phase should only be added in final Application using frameworks, not a framework itself. Tell me if it makes sense to you :)

amarunko commented 5 years ago

Hi, @zocario , make sense, thank you for you PR, I'll test it.

amarunko commented 5 years ago

@zocario, tested, works as expected, thanks!