exyte / fan-menu

Menu with a circular layout based on Macaw
MIT License
728 stars 58 forks source link

Menus been hidden after displayed, but clickable, animation is working also. #36

Closed libern closed 5 years ago

libern commented 5 years ago

It may working in the example project, but not on new project. Latest Xcode new project with deployment target 10 Latest Master branch code.

See the video in action. 1550933952454388.mp4.zip

libern commented 5 years ago

Code is taken exactly from example project.

amarunko commented 5 years ago

Hi, @libern, Okay, I will look into the issue, thank you for reporting

Sent with GitHawk

amarunko commented 5 years ago

Sorry, but I can't reproduce the issue, can you attach ViewController with example code, for me - all works as expected.

lewis-smith commented 5 years ago

I see the same behaviour. Example app works, but in my app menu items disappear instantly. Just wanted to say that @libern is not alone.

example

lewis-smith commented 5 years ago

I have an existing project, but I copied everything from the finance example.

I was using

pod 'FanMenu', :git => 'https://github.com/exyte/fan-menu'

as the version at pod 'FanMenu' was not building for me

amarunko commented 5 years ago

@lewis-smith can you check frame of fan menu? If frame is less than appeared elements, it won't be displayed correctly

amarunko commented 5 years ago

It will be cool if you can attach your example for investigation, thanks

lewis-smith commented 5 years ago

I’ve moved on from fanmenu now so not in a position to recheck, but I believe I used the same constraints as in the finance demo view. I had checked in reveal and the although some of the view is off screen(as in the demo), there did seem to be enough above for it to work


From: Anton Marunko notifications@github.com Sent: Monday, March 11, 2019 6:29 pm To: exyte/fan-menu Cc: Lewis Smith; Mention Subject: Re: [exyte/fan-menu] Menus been hidden after displayed, but clickable, animation is working also. (#36)

It will be cool if you can attach your example for investigation, thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/exyte/fan-menu/issues/36#issuecomment-471664609, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB0TGZkLVe4LN8yi4odnZEuxf_1xwGxIks5vVqCWgaJpZM4bN_Ir.

libern commented 5 years ago

@lewis-smith whats your alternative?

Appswage commented 5 years ago

I had the same issue in terms of the menu items collapsing immediately after presentation. However, the point by @amarunko was the solution. The frame was too small for the presented menu items. Once the frame was made large enough, the buttons stayed extended.

mgoldin commented 5 years ago

Added waring, that will show required fanMenu size if needed