exyte / fan-menu

Menu with a circular layout based on Macaw
MIT License
728 stars 58 forks source link

Xcode 11.4 / Swift 5.2 #52

Closed ebeneezer closed 4 years ago

ebeneezer commented 4 years ago

Dear Fan-Menu team,

i am trying out your interesting Pod on CocoaPods - alas it does not seem to compile with Xcode 11.4 Swift 5.2 respectively. Seems some incompatibility with the Macaw library, that was updated for Swift 5.2.

Will there be an update to the FanMenu pod?

Regards, Mike

JuanpabloMacias commented 4 years ago

Dear Fan-Menu team,

The same thing is happening in my project. I get this error in the open class Gradient: Fill. Error: Overridden method 'equals' has generic signature which is incompatible with base method's generic signature ; expected generic signature to be

Thank you for your help, Juanpablo

BalthazarJam commented 4 years ago

There’s a fix on github

On 29 Mar 2020, at 16:21, Juanpablo Macias notifications@github.com wrote:

 Dear Fan-Menu team,

The same thing is happening in my project. I get this error in the open class Gradient: Fill. Error: Overridden method 'equals' has generic signature which is incompatible with base method's generic signature ; expected generic signature to be

Thank you for your help, Juanpablo

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ebeneezer commented 4 years ago

That may be so - question was if the Fan-Menu CocoaPods pod would be updated.

shipinev commented 4 years ago

Hey guys. Currently, Swift 5.2 support for Macaw available only in the master branch. Since we depend on the stable Macaw version, we are waiting for the release.

BalthazarJam commented 4 years ago

The ‘fix’ is what is required to update the Macaw code that causes the problem with Swift 5.2, hence updating the implementation of the Fan-Menu CocoaPods pod for Swift 5.2.

On 30 Mar 2020, at 06:31, ebeneezer notifications@github.com wrote:

 That may be so - question was if the Fan-Menu CocoaPods pod would be updated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

shipinev commented 4 years ago

I have good news for you. Macaw released an update a few days ago. Don't forget to run pod update to update FanMenu dependencies.