eyadgaran / SimpleML

Machine learning that just works, for effortless production applications
BSD 3-Clause "New" or "Revised" License
17 stars 5 forks source link

Allow user to request a raised exception if hash(content) will be inconsistent #107

Closed ptoman-pa closed 1 year ago

ptoman-pa commented 2 years ago

Allows user to have custom_hasher raise ValueError if it cannot identify a consistent-across-instantiations hash for the object.

This is valuable because we've found it very easy to create artifacts that are impossible to get reused, because they have data in their config that can’t be represented as Python primitives. Currently you can’t possibly know if you’ve created such an artifact until you try to rerun and notice it’s taking a long time / the reuse is not being picked up, or unless you look at the db. This change supports users in reducing the cycle time to identify this error.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2668367280


Changes Missing Coverage Covered Lines Changed/Added Lines %
simpleml/persistables/hashing.py 1 3 33.33%
<!-- Total: 1 3 33.33% -->
Totals Coverage Status
Change from base Build 2287835176: 0%
Covered Lines: 2751
Relevant Lines: 4631

💛 - Coveralls